Fix & test qrep pause/unpause #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
test-pause-qrep-xmin
branch
3 times, most recently
from
a5421c5 to
6d714f2
Compare
|
Failures here are showing that temporal testsuite is not suitable for integration testing because ContinueAsNew isn't handled Looks like even children workflows return continue as new error instead of behaving as they should |
serprex
force-pushed
the
test-pause-qrep-xmin
branch
from
6d714f2 to
a19df84
Compare
|
@serprex is there a way to prevent |
|
Yes, we'd have to pass a log level when invoking Will do so in a separate PR (I tried to avoid some issue by using |
serprex
force-pushed
the
test-pause-qrep-xmin
branch
from
c68cd13 to
b46ff1e
Compare
serprex
force-pushed
the
test-pause-qrep-xmin
branch
from
779263c to
c64baba
Compare
serprex
force-pushed
the
test-pause-qrep-xmin
branch
from
bc0a7cc to
9d5bff7
Compare
iskakaushik
approved these changes
Mar 5, 2024
heavycrystal
added a commit
that referenced
this pull request
Mar 5, 2024
`postgresql` appears to be a plugin that doesn't support Temporal [advanced visibility](https://docs.temporal.io/visibility#advanced-visibility) which we use in `flow-api`. It now crashes on startup. Reverting the change made in #1388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is apt to happen when adding tests, also fix pause/unpause for qrep/xmin
waitForNewRowswould prevent pausing; use a selector to wait on signals while waiting on new rows while waiting on context cancelationCurrentFlowStatuswasn't being set to RUNNING when exiting from PAUSEDAs an aside, it turns out all the qrep/xmin tests are doing
InitialCopyOnlybesides this new testAlso remove
DisableWaitForNewRowsbecause it's unused & is meant to diverge testing from reality